Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for google_netapp_backup resource in netapp volumes #10858

Merged

Conversation

roop2
Copy link
Contributor

@roop2 roop2 commented Jun 3, 2024

Adding support for google_netapp_backup resource in netapp volumes

Release Note Template for Downstream PRs (will be copied)

`google_netapp_backup`

Copy link

github-actions bot commented Jun 3, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1163 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1163 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 137 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_backup (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_backup" "primary" {
  description = # value needed
  labels      = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • netapp

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetappbackup_netappBackupExample|TestAccNetappbackup_netappBackupFull

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappbackup_netappBackupExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappbackup_netappBackupFull[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1161 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1161 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 137 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_netapp_backup (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_netapp_backup" "primary" {
  description = # value needed
  labels      = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetappbackup_netappBackupFull

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappbackup_netappBackupFull[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1166 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1166 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 137 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 15
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetappbackup_netappBackupFull

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappbackup_netappBackupFull[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

mmv1/products/netapp/backup.yaml Outdated Show resolved Hide resolved
mmv1/products/netapp/backup.yaml Outdated Show resolved Hide resolved
mmv1/products/netapp/backup.yaml Outdated Show resolved Hide resolved
mmv1/products/netapp/backup.yaml Outdated Show resolved Hide resolved
Moving output only fields to string

Adding update test for the resource
@github-actions github-actions bot requested a review from melinath June 6, 2024 12:48
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1234 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1234 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 137 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetappbackup_netappBackupFull_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappbackup_netappBackupFull_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@roop2 roop2 requested a review from okrause June 6, 2024 15:48
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, two tiny things

mmv1/products/netapp/backup.yaml Outdated Show resolved Hide resolved
mmv1/products/netapp/backup.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from melinath June 7, 2024 05:26
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1234 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1234 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 106 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 137 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@melinath melinath merged commit 0f4f6b5 into GoogleCloudPlatform:main Jun 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants