Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): jsonify missing tests and move template into DIFF_COMMIT.md #10816

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

iyabchen
Copy link
Contributor

@iyabchen iyabchen commented May 29, 2024

For issue hashicorp/terraform-provider-google#17634
Jsonify missing tests results and move the original missing tests template into DIFF_COMMIT.md.

Triggered a missing test with the code in this PR in here: #10827

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@iyabchen iyabchen marked this pull request as ready for review May 29, 2024 19:34
@github-actions github-actions bot requested a review from shuyama1 May 29, 2024 19:34
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

2 similar comments
Copy link

github-actions bot commented Jun 1, 2024

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Jun 2, 2024

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you and sorry for the delay in review.

@shuyama1
Copy link
Member

shuyama1 commented Jun 3, 2024

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

attn @melinath PR review reminder has reported for the last three consecutive days (even during weekends). Not sure if it's intended.

@melinath
Copy link
Member

melinath commented Jun 3, 2024

@shuyama1 thanks! It's not intended; I'm planning to look into it this week.

@iyabchen
Copy link
Contributor Author

iyabchen commented Jun 4, 2024

Hi @shuyama1 I don't have permission to merge, would be great if you can merge when possible.

@shuyama1
Copy link
Member

shuyama1 commented Jun 5, 2024

Hi @shuyama1 I don't have permission to merge, would be great if you can merge when possible.

oh, sorry, I didn't realize that. I'll merge and monitor the change later today.

@shuyama1 shuyama1 merged commit 575c412 into GoogleCloudPlatform:main Jun 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants