-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): jsonify missing tests and move template into DIFF_COMMIT.md #10816
chore(ci): jsonify missing tests and move template into DIFF_COMMIT.md #10816
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
2 similar comments
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you and sorry for the delay in review.
attn @melinath PR review reminder has reported for the last three consecutive days (even during weekends). Not sure if it's intended. |
@shuyama1 thanks! It's not intended; I'm planning to look into it this week. |
Hi @shuyama1 I don't have permission to merge, would be great if you can merge when possible. |
oh, sorry, I didn't realize that. I'll merge and monitor the change later today. |
For issue hashicorp/terraform-provider-google#17634
Jsonify missing tests results and move the original missing tests template into DIFF_COMMIT.md.
Triggered a missing test with the code in this PR in here: #10827
Release Note Template for Downstream PRs (will be copied)