Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove firestore project and its reference #10505

Merged
merged 1 commit into from
May 7, 2024

Conversation

iyabchen
Copy link
Contributor

@iyabchen iyabchen commented Apr 20, 2024

remove firestore project and its reference
hashicorp/terraform-provider-google#17775

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3 insertions(+), 37 deletions(-))
google-beta provider: Diff ( 1 file changed, 11 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3620
Passed tests: 3255
Skipped tests: 365
Affected tests: 0

Click here to see the affected service packages
all service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@iyabchen iyabchen marked this pull request as ready for review May 1, 2024 20:15
@iyabchen iyabchen requested a review from melinath May 1, 2024 20:15
@melinath melinath requested review from a team and slevenick and removed request for melinath and a team May 1, 2024 21:40
@melinath melinath requested a review from SarahFrench May 6, 2024 17:47
Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the TeamCity-related changes. The changes make sense looking at them, the TeamCity tests are passing, and if I run some Firestore tests with in the current TeamCity setup with the environment variable set to a nonsense variable I can see that acc tests pass

@roaks3
Copy link
Contributor

roaks3 commented May 7, 2024

Fly-by comment: it looks like the prior usage was removed here #10168

@melinath melinath merged commit c6ac001 into GoogleCloudPlatform:main May 7, 2024
17 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants