-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AuthConfig resource in Integrations product #10335
Add AuthConfig resource in Integrations product #10335
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
f6429f6
to
bc182e2
Compare
Hi @rileykarson |
/gcbrun |
@rohitjangid Sorry, there's an issue in our CI. Would you mind rebasing your PR to catch the latest fix? Thank you! |
bc182e2
to
6dfd0bf
Compare
@shuyama1 Thank you! Done |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_integrations_auth_config" "primary" {
expiry_notification_duration = # value needed
override_valid_time = # value needed
visibility = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccIntegrationsAuthConfig_integrationsAuthConfigAuthTokenExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigBasicExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigClientCertificateOnlyExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigJwtExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOauth2AuthorizationCodeExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOauth2ClientCredentialsExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOidcTokenExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigServiceAccountExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigUsernameAndPasswordExample |
|
6dfd0bf
to
af36cf1
Compare
af36cf1
to
a430d61
Compare
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccIntegrationsAuthConfig_integrationsAuthConfigAdvanceExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigAuthTokenExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigBasicExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigClientCertificateOnlyExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigJwtExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOauth2AuthorizationCodeExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOauth2ClientCredentialsExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOidcTokenExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigServiceAccountExample|TestAccIntegrationsAuthConfig_update|TestAccSqlUser_postgresIAM |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an error message I can't figure out next steps on:
Error: Error creating AuthConfig: googleapi: Error 404: Project {{num}} doesn't have correct KMS configs set up, P4SA - service-{{num}}@gcp-sa-integrations.iam.gserviceaccount.com, keyring - , key - , location - .
mmv1/third_party/terraform/services/integrations/resource_integrations_auth_config_test.go
Outdated
Show resolved
Hide resolved
a430d61
to
f66bfc2
Compare
f66bfc2
to
0cf84a6
Compare
This is related to incorrect provisioning of client. I would get it fixed on our api side. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_integrations_auth_config" "primary" {
certificate_id = # value needed
client_certificate = # value needed
create_time = # value needed
creator_email = # value needed
credential_type = # value needed
decrypted_credential = # value needed
decrypted_credential {
auth_token = # value needed
jwt = # value needed
jwt {
jwt = # value needed
}
oauth2_authorization_code = # value needed
oauth2_client_credentials = # value needed
oauth2_client_credentials {
token_params = # value needed
token_params {
entries = # value needed
entries {
key = # value needed
key {
literal_value = # value needed
}
value = # value needed
value {
literal_value = # value needed
}
}
}
}
oidc_token = # value needed
oidc_token {
token = # value needed
token_expire_time = # value needed
}
service_account_credentials = # value needed
username_and_password = # value needed
}
encrypted_credential = # value needed
last_modifier_email = # value needed
name = # value needed
project = # value needed
reason = # value needed
state = # value needed
update_time = # value needed
valid_time = # value needed
}
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_integrations_auth_config" "primary" {
certificate_id = # value needed
client_certificate = # value needed
create_time = # value needed
creator_email = # value needed
credential_type = # value needed
decrypted_credential = # value needed
decrypted_credential {
auth_token = # value needed
jwt = # value needed
jwt {
jwt = # value needed
}
oauth2_authorization_code = # value needed
oauth2_client_credentials = # value needed
oauth2_client_credentials {
token_params = # value needed
token_params {
entries = # value needed
entries {
key = # value needed
key {
literal_value = # value needed
}
value = # value needed
value {
literal_value = # value needed
}
}
}
}
oidc_token = # value needed
oidc_token {
token = # value needed
token_expire_time = # value needed
}
service_account_credentials = # value needed
username_and_password = # value needed
}
encrypted_credential = # value needed
last_modifier_email = # value needed
name = # value needed
project = # value needed
reason = # value needed
state = # value needed
update_time = # value needed
valid_time = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccHealthcareDatasetIamPolicy|TestAccIntegrationsAuthConfig_integrationsAuthConfigAdvanceExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigAuthTokenExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigClientCertificateOnlyExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigJwtExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOauth2AuthorizationCodeExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOauth2ClientCredentialsExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOidcTokenExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigServiceAccountExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigUsernameAndPasswordExample|TestAccIntegrationsAuthConfig_update |
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccIntegrationsAuthConfig_integrationsAuthConfigAdvanceExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigAuthTokenExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigClientCertificateOnlyExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigJwtExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOauth2AuthorizationCodeExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOauth2ClientCredentialsExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOidcTokenExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigServiceAccountExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigUsernameAndPasswordExample|TestAccIntegrationsAuthConfig_update |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can ignore the missing field detector for now- it's either getting confused or we found a bug.
5351768
to
8926cc0
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_integrations_auth_config" "primary" {
project = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccIntegrationsAuthConfig_integrationsAuthConfigAdvanceExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigAuthTokenExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigClientCertificateOnlyExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigJwtExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOauth2AuthorizationCodeExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOauth2ClientCredentialsExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigOidcTokenExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigServiceAccountExample|TestAccIntegrationsAuthConfig_integrationsAuthConfigUsernameAndPasswordExample|TestAccIntegrationsAuthConfig_update |
|
8926cc0
to
194ce80
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_integrations_auth_config" "primary" {
project = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccIntegrationsAuthConfig_integrationsAuthConfigAdvanceExample |
|
194ce80
to
d20c025
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_integrations_auth_config" "primary" {
project = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
@rileykarson The tests are passing now. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Add support to manage Application Integration Auth Config via terraform
Release Note Template for Downstream PRs (will be copied)
Fixes hashicorp/terraform-provider-google#17736