Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cilium clusterwide network policies support #10225

Merged

Conversation

maxi-cit
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#17620

Release Note Template for Downstream PRs (will be copied)

container: added `enable_cilium_clusterwide_network_policy` field to `google_container_cluster` resource

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from NickElliot March 19, 2024 15:29
@maxi-cit
Copy link
Contributor Author

maxi-cit commented Mar 19, 2024

Hello all, this library needs to get enhanced to include the EnableCiliumClusterwideNetworkPolicy and DesiredEnableCiliumClusterwideNetworkPolicy attributes

@NickElliot
Copy link
Contributor

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 21, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 37 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 2 files changed, 39 insertions(+), 11 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log

@maxi-cit
Copy link
Contributor Author

maxi-cit commented Mar 23, 2024

FYI I bumped the google.golang.org/api lib using

go get -u google.golang.org/api@latest

because it contains the support for the required field for this PR. I will be adding some integration tests comming week

@NickElliot
Copy link
Contributor

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 436 insertions(+), 345 deletions(-))
google-beta provider: Diff ( 4 files changed, 478 insertions(+), 406 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
all service packages are affected

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log

@maxi-cit
Copy link
Contributor Author

Hello @NickElliot, I think I am ready for another round of review.

I added two tests that showcase the support of the field for standar cluster and autopilot mode.

PD: should I add the golang lib bumping within the changelog?

@NickElliot
Copy link
Contributor

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 26, 2024
@NickElliot
Copy link
Contributor

Can you resolve the newly arisen conflicts? Sorry I keep trying to review this today but it keeps needing the test reran and now this came up 😅

@maxi-cit
Copy link
Contributor Author

Hello @NickElliot , it makes sense since all contribute to the same go dependency. So I tried to keep the latest versions of all libraries. go.sum should be updated as well

@NickElliot
Copy link
Contributor

/gcbrun

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 27, 2024
@modular-magician modular-magician added service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 27, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 321 insertions(+), 22 deletions(-))
google-beta provider: Diff ( 5 files changed, 323 insertions(+), 24 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3547
Passed tests: 3177
Skipped tests: 367
Affected tests: 3

Click here to see the affected service packages
all service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_enableCiliumPolicies|TestAccContainerCluster_enableCiliumPolicies_withAutopilot|TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_enableCiliumPolicies[Debug log]
TestAccContainerCluster_enableCiliumPolicies_withAutopilot[Debug log]
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxi-cit
Copy link
Contributor Author

Hello @NickElliot, it seems that tests are ok. Is there anything that is blocking this merge?

@NickElliot NickElliot merged commit f1f0e24 into GoogleCloudPlatform:main Apr 1, 2024
12 checks passed
pjotrekk pushed a commit to pjotrekk/magic-modules that referenced this pull request Apr 2, 2024
rafalmaczewski pushed a commit to rafalmaczewski/magic-modules that referenced this pull request Apr 3, 2024
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cilium Network Policies support for GKE
3 participants