-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cilium clusterwide network policies support #10225
add cilium clusterwide network policies support #10225
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb
Show resolved
Hide resolved
Hello all, this library needs to get enhanced to include the |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
…s-to-cluster sync merge from upstream/main
FYI I bumped the google.golang.org/api lib using
because it contains the support for the required field for this PR. I will be adding some integration tests comming week |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected
|
Hello @NickElliot, I think I am ready for another round of review. I added two tests that showcase the support of the field for standar cluster and autopilot mode. PD: should I add the golang lib bumping within the changelog? |
/gcbrun |
Can you resolve the newly arisen conflicts? Sorry I keep trying to review this today but it keeps needing the test reran and now this came up 😅 |
…s-to-cluster sync merge from upstream/main
Hello @NickElliot , it makes sense since all contribute to the same go dependency. So I tried to keep the latest versions of all libraries. go.sum should be updated as well |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_enableCiliumPolicies|TestAccContainerCluster_enableCiliumPolicies_withAutopilot|TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hello @NickElliot, it seems that tests are ok. Is there anything that is blocking this merge? |
Fixes: hashicorp/terraform-provider-google#17620
Release Note Template for Downstream PRs (will be copied)