Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestAccContainerCluster_withInvalidAutoscalingProfile #10218

Closed
wants to merge 1 commit into from
Closed

Fix TestAccContainerCluster_withInvalidAutoscalingProfile #10218

wants to merge 1 commit into from

Conversation

jbartosik
Copy link

@jbartosik jbartosik commented Mar 18, 2024 •
edited
Loading

Replies now include quotes around the expected values of enum

fix hashicorp/terraform-provider-google#17383

@jbartosik
Fix TestAccContainerCluster_withInvalidAutoscalingProfile
c54554e 
Replies now include quotes around the expected values of enum
fix #17383
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from BBBmau March 18, 2024 14:59
@jbartosik
Copy link
Author

I think this is a wrong repo for the fix

@jbartosik jbartosik closed this Mar 18, 2024
@jbartosik jbartosik reopened this Mar 19, 2024
@jbartosik
Copy link
Author

This passed locally I tested by:

  • generating changes: make provider VERSION=ga OUTPUT_PATH="/Users/jbartosik/go/src/github.com/hashicorp/terraform-provider-google" PRODUCT=container
  • running test make testacc TEST=./google/services/container TESTARGS='-run=TestAccContainerCluster_withInvalidAutoscalingProfile'

The test passed:

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/container -v -run=TestAccContainerCluster_withInvalidAutoscalingProfile -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccContainerCluster_withInvalidAutoscalingProfile
=== PAUSE TestAccContainerCluster_withInvalidAutoscalingProfile
=== CONT  TestAccContainerCluster_withInvalidAutoscalingProfile
2024/03/19 14:54:23 [INFO] Authenticating using DefaultClient...
2024/03/19 14:54:23 [INFO]   -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/03/19 14:54:23 [INFO] Authenticating using DefaultClient...
2024/03/19 14:54:23 [INFO]   -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/03/19 14:54:23 [DEBUG] Waiting for state to become: [success]
2024/03/19 14:54:23 [INFO] Terraform is using this identity: [email protected]
2024/03/19 14:54:23 [DEBUG] Getting shared test network "tf-bootstrap-net-gke-cluster"
2024/03/19 14:54:23 [INFO] Instantiating GCE client for path https://compute.googleapis.com/compute/v1/
2024/03/19 14:54:23 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/03/19 14:54:23 [DEBUG] Retry Transport: request attempt 0
2024/03/19 14:54:23 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/03/19 14:54:23 [DEBUG] Retry Transport: Returning after 1 attempts
2024/03/19 14:54:23 [INFO] Instantiating GCE client for path https://compute.googleapis.com/compute/v1/
2024/03/19 14:54:23 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/03/19 14:54:23 [DEBUG] Retry Transport: request attempt 0
2024/03/19 14:54:24 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/03/19 14:54:24 [DEBUG] Retry Transport: Returning after 1 attempts
2024/03/19 14:54:24 [INFO] Authenticating using DefaultClient...
2024/03/19 14:54:24 [INFO]   -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/03/19 14:54:24 [INFO] Authenticating using DefaultClient...
2024/03/19 14:54:24 [INFO]   -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/03/19 14:54:24 [DEBUG] Waiting for state to become: [success]
2024/03/19 14:54:24 [INFO] Terraform is using this identity: [email protected]
2024/03/19 14:54:24 [INFO] Instantiating GCE client for path https://compute.googleapis.com/compute/v1/
2024/03/19 14:54:24 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/03/19 14:54:24 [DEBUG] Retry Transport: request attempt 0
2024/03/19 14:54:24 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/03/19 14:54:24 [DEBUG] Retry Transport: Returning after 1 attempts
2024/03/19 14:54:24 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/03/19 14:54:24 [DEBUG] Retry Transport: request attempt 0
2024/03/19 14:54:25 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/03/19 14:54:25 [DEBUG] Retry Transport: Returning after 1 attempts
--- PASS: TestAccContainerCluster_withInvalidAutoscalingProfile (2.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-google/google/services/container	4.115s

@BBBmau
Copy link
Collaborator

BBBmau commented Mar 19, 2024

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 19, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 185
Passed tests: 173
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@slevenick
Copy link
Contributor

/gcbrun I'm not sure what that failing build is

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 22, 2024
@slevenick
Copy link
Contributor

/gcbrun

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 22, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 185
Passed tests: 173
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@kushagra98
Copy link

Created - #10277

@BBBmau
Copy link
Collaborator

BBBmau commented Mar 26, 2024

Closing since this was fixed in #10277

@BBBmau BBBmau closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBBmau BBBmau Awaiting requested review from BBBmau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccContainer*_withInvalid*
5 participants
@jbartosik @BBBmau @modular-magician @slevenick @kushagra98