Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New samples: Kueue cohort tutorial #534

Merged
merged 8 commits into from
Apr 11, 2023
Merged

New samples: Kueue cohort tutorial #534

merged 8 commits into from
Apr 11, 2023

Conversation

rbarberop
Copy link
Collaborator

This PR contains the yaml examples for the new Kueue tutorial using cohorts for resource sharing.

Code is v1beta1

@rbarberop rbarberop requested a review from alizaidis as a code owner March 28, 2023 17:45
@snippet-bot
Copy link

snippet-bot bot commented Mar 28, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@rbarberop
Copy link
Collaborator Author

@alculquicondor FYI

@rbarberop
Copy link
Collaborator Author

@Shabirmean #498 closed in favor of this one

alculquicondor
alculquicondor reviewed Mar 28, 2023
View reviewed changes
Copy link

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

batch/kueue-cohort/team-a-job.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/team-b-job.yaml Outdated Show resolved Hide resolved
@rbarberop rbarberop enabled auto-merge (squash) March 28, 2023 19:25
@alculquicondor
Copy link

/lgtm

@rbarberop rbarberop disabled auto-merge March 29, 2023 13:24
@rbarberop
Copy link
Collaborator Author

Wait for more testing before merging...

bourgeoisor
bourgeoisor approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know when this is good to merge.

@bourgeoisor bourgeoisor changed the title samples: Kueue cohort tutorial samples New samples: Kueue cohort tutorial Mar 30, 2023
alculquicondor
alculquicondor reviewed Mar 30, 2023
View reviewed changes
batch/kueue-cohort/flavors.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/flavors.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/team-b-job.yaml Outdated Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Mar 31, 2023
View reviewed changes
Copy link

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbarberop
Copy link
Collaborator Author

Blocked on kubernetes-sigs/kueue#659

@rbarberop
Copy link
Collaborator Author

@bourgeoisor all blocks have been lifted, this is ready to merge

@rbarberop rbarberop enabled auto-merge (squash) April 11, 2023 13:36
@bourgeoisor bourgeoisor disabled auto-merge April 11, 2023 15:45
@bourgeoisor bourgeoisor merged commit 66977ef into GoogleCloudPlatform:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@alizaidis alizaidis Awaiting requested review from alizaidis alizaidis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbarberop @alculquicondor @bourgeoisor