Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compute): delete old unused region tags after migration #9998

Conversation

alarconesparza
Copy link
Contributor

@alarconesparza alarconesparza commented Jan 29, 2025

Description

Fixes
Internal
b/347825209
b/347825167

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels Jan 29, 2025
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello everyone,

I'm Gemini, and I'm currently reviewing this pull request. In the meantime, I'm providing a summary of its content to help you and other reviewers quickly understand the changes and intent.

This pull request, authored by alarconesparza, aims to delete old, unused region tags after a migration. The changes are focused on cleaning up the compute/error-reporting directory:

  • compute/error-reporting/pom.xml: Removed redundant comment blocks (<!-- [START dependencies] --> and <!-- [END dependencies] -->) from lines 40-46. This simplifies the file and improves readability.
  • compute/error-reporting/src/main/java/com/example/compute/errorreporting/ExceptionUtil.java: Removed redundant comment blocks (// [START example] and // [END example]) from lines 26 and 50. This also cleans up the code and improves readability. The changes are minimal and purely cosmetic, focusing on code cleanup.

The pull request addresses internal issues b/347825209 and b/347825167. The author has included a checklist confirming adherence to the sample format guide and successful test runs (mvn clean verify and mvn -P lint checkstyle:check).

I'll have a more detailed review shortly. Until then, I hope this summary is helpful!

And now, a little haiku to lighten the mood:

Old tags now removed,
Code cleaner, bright and new,
Joy in the clean code.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request removes outdated region tags in compute/error-reporting/pom.xml and compute/error-reporting/src/main/java/com/example/compute/errorreporting/ExceptionUtil.java. The changes are minimal and appear to be correct. However, the pull request description could be improved and some minor adjustments to the code are recommended.

Summary of Style Guide References: I've referenced general Java best practices and conventions in this review, including the use of comments and the removal of unnecessary code.

Recommendations for Approval:

  • Update the pull request description to be more informative.
  • Address the comments below regarding comments and code style.

@alarconesparza alarconesparza marked this pull request as ready for review January 29, 2025 22:02
@alarconesparza alarconesparza requested review from yoshi-approver and a team as code owners January 29, 2025 22:02
Copy link

snippet-bot bot commented Jan 29, 2025

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion merged commit a965c4e into GoogleCloudPlatform:main Feb 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants