Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to new client library and fixes broken link in README #427

Merged
merged 5 commits into from
Dec 1, 2016
Merged

Updates to new client library and fixes broken link in README #427

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81d550f
Updates to new client library and fixes broken link in README
gguuss Nov 28, 2016
4baae60
Fixes error on test
gguuss Nov 28, 2016
a5f7fc0
Fixes type in test assertion
gguuss Nov 28, 2016
bd07872
Removes extraneous createService method, reduces line length in integ…
gguuss Nov 30, 2016
dad9f17
Merge branch 'master' into language-client
lesv Dec 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes error on test
  • Loading branch information
@gguuss
gguuss committed Nov 28, 2016
commit 4baae603a70f1463bf5f2480a57bf05045b1cc1b
3 changes: 2 additions & 1 deletion language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import static com.google.common.truth.Truth.assertThat;

import com.google.cloud.language.v1.Entity;
import com.google.cloud.language.v1.PartOfSpeech.Tag;
import com.google.cloud.language.v1.Sentiment;
import com.google.cloud.language.v1.Token;

Expand Down Expand Up @@ -85,7 +86,7 @@ public class AnalyzeIT {
analyzeApp.analyzeSyntax(
"President Obama was elected for the second term");

List<String> got = token.stream().map(e -> e.getPartOfSpeech().getTag())
List<Tag> got = token.stream().map(e -> e.getPartOfSpeech().getTag())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea - Java 8. Good to see, but we don't typically use this in samples. Note - I'm Ok w/ this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Leaving as-is.

.collect(Collectors.toList());

// Assert
Expand Down