feat: dataproc quickstart and createcluster #1908
Conversation
bradmiro
commented
Dec 26, 2019
bradmiro
commented
- adding quickstart sample + test
- updating createCluster + test
- updating pom
googlebot
added
the
cla: yes
| deleteClusterAsyncRequest.get(); | ||
| System.out.println(String.format("Cluster \"%s\" successfully deleted.", clusterName)); | ||
|
|
||
| } catch (ExecutionException e) { |
There was a problem hiding this comment.
If ExecutionException occurs from interacting with the API (like it's thrown if you don't have permission or if your request is misconfigured), keep it and clarify that it's an error from interacting with the service with the println.
If it's not from the API, please let it bubble up (and be consistent with the other samples - it's bubbled up in a few other places).
There was a problem hiding this comment.
Ahh yes, I see what you're saying. Errors caused by our API bubble up to be an Execution Exception, so I think it should definitely be caught. I'll add it to the other sample.
|
You may also need to truncate your UUID:
|
* Added dataproc quickstart samples * Fixed linting, string formatting, copyrights * added overloaded functions to all samples * Formatting changes * small bug fixes * Fixed CreateCluster sample and added Quickstart * Added quickstart sample * Added dataproc quickstart samples * Fixed linting, string formatting, copyrights * added overloaded functions to all samples * Formatting changes * small bug fixes * Fixed CreateCluster sample and added Quickstart * Added quickstart sample * Updates to createCluster and quickstart * Fixed quickstart and tests * Changes to tests * Added periods to comments * Fixed pom and added handling for ExecutionException * Fixed lint errors * Fixed linting errors
