Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update streaming sample to use non-deprecated method #1413

Merged
merged 2 commits into from
May 13, 2019
Merged

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented May 10, 2019

No description provided.

@nnegrey nnegrey requested review from nirupa-kumar, dzlier-gcp and a team May 10, 2019 21:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2019
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you deleted the pom.xml, but other than that LGTM

@nnegrey
Copy link
Contributor Author

nnegrey commented May 13, 2019

Not completely deleted, just removed a bunch of old profiles for running the samples, but since we removed the main() awhile back, I deleted them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants