Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAE quickstart tutorial uses different appengine plugin #559

Closed
shinfan opened this issue Mar 13, 2017 · 11 comments
Closed

GAE quickstart tutorial uses different appengine plugin #559

shinfan opened this issue Mar 13, 2017 · 11 comments

Comments

@shinfan
Copy link

shinfan commented Mar 13, 2017

In the GAE quick-start tutorial it uses:

<groupId>com.google.cloud.tools</groupId>
<artifactId>appengine-maven-plugin</artifactId>
<version>${appengine-maven-plugin-version}</version>

which is different from the one used by sample. We should switch either one of them to keep them consistent.

@shinfan
Copy link
Author

shinfan commented Mar 13, 2017

@lesv

@jerjou
Copy link
Contributor

jerjou commented Mar 14, 2017

@tswast Would you mind looking at this? I believe this is referring to the tutorial within the cloud console, that uses this code. Let me know if you don't have bandwidth, and I can take a shot at it (I figure it might be easier for you, though, if you're familiar with how to modify cloud-console tutorials)

@lesv
Copy link
Contributor

lesv commented Mar 15, 2017

This is actually a problem in Neos -- it shouldn't be using the new plugin yet. Not sure where that hides.

@tswast
Copy link
Contributor

tswast commented Mar 15, 2017

What plugin should it use? Previously it was using the gcloud plugin to do deploys to App Engine standard because the old plugin was never updated to support deploys from Cloud Shell. See internal bug 33192132 where I updated the sample to the new plugin.

@lesv
Copy link
Contributor

lesv commented Mar 15, 2017

This is for GAE Std, I think, and all GAE Std deploy should use the Java SDK plugin. GAE Flex should all use the gcloud SDK plugin.

There used to be a Flex plugin called gcloud that is deprecated. Confusing? Yep.

@tswast
Copy link
Contributor

tswast commented Mar 15, 2017

Yeah, except we can't use the Java SDK plugin in Neos because it doesn't understand the Cloud Shell credentials.

@lesv
Copy link
Contributor

lesv commented Mar 15, 2017

@shinfan I'm going to close this in 24h, unless you object.
@ludoch FYI - you might wish to go through the new user experience customers go through. (you might also object)

@ludoch
Copy link
Contributor

ludoch commented Mar 15, 2017

Did you try the flag --service_account_json_key_file=path in the GA plugin?

https://cloud.google.com/appengine/docs/standard/java/tools/appcfg-arguments

@tswast
Copy link
Contributor

tswast commented Mar 15, 2017 via email

@tswast
Copy link
Contributor

tswast commented Mar 15, 2017

It would seem like the --use_google_application_default_credentials would work, but it does not. See internal bug 28788572.

@jerjou
Copy link
Contributor

jerjou commented Mar 17, 2017

Okay - it sounds like this would be more trouble than it's worth. Consistency would be great, but I think the onus is on the maven plugin team to make their plugins consistent (as opposed to on the samples, that are just doing what works).

@jerjou jerjou closed this as completed Mar 17, 2017
minherz pushed a commit that referenced this issue Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz pushed a commit that referenced this issue Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz pushed a commit that referenced this issue Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
bourgeoisor pushed a commit that referenced this issue Nov 11, 2022
…en-plugin to v1.6.12 (#559)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.sonatype.plugins:nexus-staging-maven-plugin](http://www.sonatype.com/) ([source](https://github.com/sonatype/nexus-maven-plugins)) | `1.6.11` -> `1.6.12` | [![age](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.12/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.12/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.12/compatibility-slim/1.6.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.12/confidence-slim/1.6.11)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-notification).
anguillanneuf pushed a commit that referenced this issue Nov 15, 2022
…#559)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://github.com/googleapis/java-core) | `1.95.1` -> `1.95.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/1.95.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/1.95.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/1.95.2/compatibility-slim/1.95.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/1.95.2/confidence-slim/1.95.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v1.95.2`](https://github.com/googleapis/java-core/blob/master/CHANGELOG.md#&#8203;1952-httpswwwgithubcomgoogleapisjava-corecomparev1951v1952-2021-06-09)

[Compare Source](https://github.com/googleapis/java-core/compare/v1.95.1...v1.95.2)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).
Sita04 pushed a commit that referenced this issue Feb 7, 2023
…3.3 (#559)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-pubsub](https://github.com/googleapis/java-pubsub) | `1.113.0` -> `1.113.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-pubsub/1.113.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-pubsub/1.113.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-pubsub/1.113.3/compatibility-slim/1.113.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-pubsub/1.113.3/confidence-slim/1.113.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-pubsub</summary>

### [`v1.113.3`](https://github.com/googleapis/java-pubsub/blob/master/CHANGELOG.md#&#8203;11133-httpswwwgithubcomgoogleapisjava-pubsubcomparev11132v11133-2021-06-09)

[Compare Source](https://github.com/googleapis/java-pubsub/compare/v1.113.2...v1.113.3)

### [`v1.113.2`](https://github.com/googleapis/java-pubsub/blob/master/CHANGELOG.md#&#8203;11132-httpswwwgithubcomgoogleapisjava-pubsubcomparev11131v11132-2021-06-09)

[Compare Source](https://github.com/googleapis/java-pubsub/compare/v1.113.1...v1.113.2)

### [`v1.113.1`](https://github.com/googleapis/java-pubsub/blob/master/CHANGELOG.md#&#8203;11131-httpswwwgithubcomgoogleapisjava-pubsubcomparev11130v11131-2021-06-07)

[Compare Source](https://github.com/googleapis/java-pubsub/compare/v1.113.0...v1.113.1)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dlp).
Sita04 pushed a commit that referenced this issue Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants