Network subsystem remove os rules #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MDS will provide us with the user's defined MTU make sure we honor it on the netplan dropin.
dorileo
force-pushed
the
network-subsystem-remove-os-rules
branch
from
c2cd7ab to
dbbfc18
Compare
We are removing the backward compatibility OS rules and assuming the detected available backend. This change also removes the notion of fallback as it was before. Additionally the rollback logic changed to "rollback all backends except the active one", the "except the active one" rule is important to prevent restarting network when no configuration change's happened. In the set we are also adding the netplan dhcp overrides directives that was resulting into misconfigured dhcp routes.
dorileo
force-pushed
the
network-subsystem-remove-os-rules
branch
from
dbbfc18 to
cf66d95
Compare
a-crate
approved these changes
Jun 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-crate, dorileo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit a743ab5
into
GoogleCloudPlatform:main
5 checks passed
a-crate
added a commit
to a-crate/guest-agent
that referenced
this pull request
Jul 22, 2024
…oogleCloudPlatform#396) Keep the refactor of general structure, netplan dhcp overrides, and netplan support for default MTU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.