Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Envoy to 1.30.7 #936

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

gopkarthik
Copy link
Contributor

@gopkarthik gopkarthik commented Nov 13, 2024

Envoy 1.30.1 to 1.30.6 are broken & was fixed in #36515. Upgrading to 1.30.7 to resolve this.

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gopkarthik
Copy link
Contributor Author

/test all

@gopkarthik
Copy link
Contributor Author

ESPv1-build passed successfully & ESPv2 images were successfully created - gcr.io/cloudesf-testing/apiproxy:ba63f7587ecde83fcf3e4c1bf2779d647539e378, gcr.io/cloudesf-testing/apiproxy-serverless:ba63f7587ecde83fcf3e4c1bf2779d647539e378.

Sending PR for review.

@gopkarthik gopkarthik marked this pull request as ready for review November 13, 2024 05:37
@gopkarthik
Copy link
Contributor Author

/retest

1 similar comment
@gopkarthik
Copy link
Contributor Author

/retest

@gopkarthik gopkarthik requested review from TAOXUY and removed request for dchakarwarti November 13, 2024 12:48
@gopkarthik
Copy link
Contributor Author

/retest

@dchakarwarti
Copy link
Contributor

Approved.

I see dependency failure related to com_googlesource_googleurl https://screenshot.googleplex.com/9sARYC2PcGcDMHH in the not required tests.

@gopkarthik
Copy link
Contributor Author

Approved.

I see dependency failure related to com_googlesource_googleurl https://screenshot.googleplex.com/9sARYC2PcGcDMHH in the not required tests.

That failure is expected since the ESPv2-API-regression-test runs the test at HEAD of master branch. https://github.com/GoogleCloudPlatform/esp-v2/blob/master/prow/gcpproxy-api-regression.sh#L58-L65

Copy link

@gopkarthik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ESPv2-presubmit-asan 4881474 link true /test ESPv2-presubmit-asan
ESPv2-API-regression-test 4881474 link true /test ESPv2-API-regression-test
ESPv2-cloud-run-e2e-cloud-function-http-bookstore 4881474 link true /test ESPv2-cloud-run-e2e-cloud-function-http-bookstore
ESPv2-presubmit-tsan 4881474 link true /test ESPv2-presubmit-tsan
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore 4881474 link true /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchakarwarti, gopkarthik, shuoyang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shuoyang2016 shuoyang2016 merged commit a73952c into GoogleCloudPlatform:master Nov 13, 2024
12 of 17 checks passed
@rongqi-g rongqi-g mentioned this pull request Nov 13, 2024
@gopkarthik gopkarthik deleted the update-envoy branch November 14, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants