Add a flag to opt out reporting api key uid and report unknown in network error. #897
Conversation
| if (info.check_response_info.error.is_network_error) { | ||
| (*labels)[l.name] = absl::StrCat(kApiKeyPrefix, "UNKNOWN"); | ||
| } else { | ||
| (*labels)[l.name] = absl::StrCat(kApiKeyPrefix, info.check_response_info.api_key_uid.empty() ? info.api_key |
There was a problem hiding this comment.
Do we still report API key if the flag is true?
There was a problem hiding this comment.
Yes, according to Chemist team, for some old apis, they don't have api_key_uid, thus we still need to report api_key when api_key_uid is empty.
| if (info.check_response_info.error.is_network_error) { | ||
| (*labels)[l.name] = absl::StrCat(kApiKeyPrefix, "UNKNOWN"); | ||
| } else { | ||
| (*labels)[l.name] = absl::StrCat(kApiKeyPrefix, info.check_response_info.api_key_uid.empty() ? info.api_key |
sure, will do it in another change. |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elliot-xq, shuoyang2016, TAOXUY The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
/retest-required |
|
@Elliot-xq: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
adds flag service_control_report_api_key_uid with default false.
TODO: enable it before release.
reports unknown in check request network failure.