Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow internal callers to inject RouteGenerator #870

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

nareddyt
Copy link
Contributor

Bubble up routeGens parameter to MakeListener, which we call internally.

Also allows us to remove ServiceInfo from MakeListener 💯 In follow-up CL, I will completely delete ServiceInfo.

Bubble up `routeGens` parameter to `MakeListener`, which we call internally.

Signed-off-by: Teju Nareddy <[email protected]>
Copy link

@nareddyt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ESPv2-presubmit-tsan 00bb51e link true /test ESPv2-presubmit-tsan
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore 00bb51e link true /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore
ESPv2-presubmit-asan 00bb51e link true /test ESPv2-presubmit-asan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nareddyt nareddyt merged commit a095b7b into GoogleCloudPlatform:master Nov 13, 2023
@nareddyt nareddyt deleted the route-gen-inject branch November 13, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants