Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce default jwt_cache_size to 1000 #798

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Reduce default jwt_cache_size to 1000 #798

merged 2 commits into from
Mar 23, 2023

Conversation

nareddyt
Copy link
Contributor

Based on discussions in #782, the original estimate was incorrect. Reduce max memory usage from ~410 MB to 4.35 MB.

Fixes #782

@nareddyt
config: reduce default jwt_cache_size
405cb23 
Based on discussions in GoogleCloudPlatform#782, the original estimate was incorrect. Reduce max memory usage from ~410 MB to 4.35 MB.

Fixes GoogleCloudPlatform#782

Signed-off-by: Teju Nareddy <[email protected]>
@nareddyt nareddyt requested review from shuoyang2016 and TAOXUY March 22, 2023 21:46
@nareddyt nareddyt self-assigned this Mar 22, 2023
@nareddyt nareddyt changed the title config: reduce default jwt_cache_size Reduce default jwt_cache_size to 1000 Mar 22, 2023
@google-oss-prow google-oss-prow bot added the lgtm label Mar 22, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nareddyt
update flag help text
77753c6 
Signed-off-by: Teju Nareddy <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Mar 22, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow
Copy link

google-oss-prow bot commented Mar 22, 2023 •
edited
Loading

@nareddyt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore 77753c6 link true /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nareddyt
Copy link
Contributor Author

/test all

@nareddyt nareddyt merged commit 66f0163 into GoogleCloudPlatform:master Mar 23, 2023
@nareddyt nareddyt deleted the jwt-cache-size branch March 23, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TAOXUY TAOXUY TAOXUY approved these changes

@shuoyang2016 shuoyang2016 Awaiting requested review from shuoyang2016

Assignees

@nareddyt nareddyt

@TAOXUY TAOXUY

Labels
approved size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak in v2.41.0?
2 participants
@nareddyt @TAOXUY