-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag --disable_jwt_audience_service_name_check #779
Conversation
/retest |
1 similar comment
/retest |
Signed-off-by: Wayne Zhang <[email protected]>
Signed-off-by: Wayne Zhang <[email protected]>
Signed-off-by: Wayne Zhang <[email protected]>
bae29d1
to
72255bb
Compare
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adjusting the flag!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nareddyt, qiwzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@qiwzhang: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
To fix: #706
Normally JWT "aud" field is checked against audiences specified in OpenAPI
x-google-audiences
field.This flag changes the behavior when the
x-google-audiences
is not specified.When the
x-google-audiences
is not specified, normally the service name is used to check the JWTaud
field.If this flag is true, the service name is not used, JWT
aud
field will not be checked.