b/149050012: Remove backend protocol flag #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
qiwzhang
reviewed
Feb 26, 2020
Signed-off-by: Teju Nareddy <[email protected]>
…rt_test.go` In that test, backend protocol was configured incorrectly. It was using a GRPC backend but configuring the protocol as HTTP. Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
qiwzhang
approved these changes
Feb 27, 2020
|
/retest |
TAOXUY
approved these changes
Feb 27, 2020
JLXIA
reviewed
Feb 27, 2020
…tegration tests Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
|
PTAL |
qiwzhang
approved these changes
Feb 27, 2020
JLXIA
reviewed
Feb 27, 2020
Signed-off-by: Teju Nareddy <[email protected]>
Signed-off-by: Teju Nareddy <[email protected]>
JLXIA
approved these changes
Feb 27, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JLXIA, nareddyt, qiwzhang, TAOXUY The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to configure the entire backend address (scheme, host, and port) in the
--backendflag. Remove the need for the--backend_protocolflag.This maintains backwards compatibility with ESPv2 via the default backend address.
Actual code changes are very minimal. Majority of changes are to unit tests and integration tests:
BackendProtocolwas required in almost all of theconfig generatorpackage.--backend_protocolflag. Remove the flag in all integration tests. Just set the flag when starting config manager.Also fix
service_control_failed_request_report_test.go. In that test, backend protocol was configured incorrectly. It was using a GRPC backend but configuring the protocol as HTTP.Signed-off-by: Teju Nareddy [email protected]