Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with GKE parallelstore related example blueprint details #3409

Merged

Conversation

mohitchaurasia91
Copy link
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@mohitchaurasia91 mohitchaurasia91 added the documentation Improvements or additions to documentation label Dec 16, 2024
@mohitchaurasia91 mohitchaurasia91 self-assigned this Dec 16, 2024
@mohitchaurasia91 mohitchaurasia91 added the release-improvements Added to release notes under the "Improvements" heading. label Dec 16, 2024
Copy link
Contributor

@ankitkinra ankitkinra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the name of this blueprint to be gke-storage-managed-parallelstore to reflect that we delete this parallelstore as well ? Although I don't know if managed still conveys the same meaning

@mohitchaurasia91
Copy link
Contributor Author

Can we update the name of this blueprint to be gke-storage-managed-parallelstore to reflect that we delete this parallelstore as well ? Although I don't know if managed still conveys the same meaning

Agree to that, it align well with terraform definition of managed resources, providing a clean separation between terraform (managed) resources and data resources.

@mohitchaurasia91 mohitchaurasia91 merged commit 6d4d8f7 into GoogleCloudPlatform:develop Dec 19, 2024
8 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants