Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IP address module within VPC module #3160

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

tpdownes
Copy link
Member

  • Support terraform-provider-google v6
  • Adds support for labels on regional IP addresses

Without this update, any blueprint that uses the vpc module will default to TPG 5.44.2 instead of 6.8.0.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@tpdownes tpdownes added the release-version-updates Added to release notes under the "Version Updates" heading. label Oct 23, 2024
Copy link
Collaborator

@RachaelSTamakloe RachaelSTamakloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe some of the golden copy test files need to be updated to reflect your recent changes.

@tpdownes tpdownes marked this pull request as draft October 24, 2024 00:17
@tpdownes
Copy link
Member Author

The tools/validate_configs/test_configs/test_outputs.yaml blueprint is failing in ways that make clear we need to update the vm-instance module as well as the new-project module. I will mark this draft until we complete that work.

@tpdownes tpdownes force-pushed the update_nat branch 2 times, most recently from d33c6fd to 43df4bf Compare October 29, 2024 01:08
- Support terraform-provider-google v6
- Adds support for labels on regional IP addresses
@tpdownes tpdownes marked this pull request as ready for review October 29, 2024 01:38
@tpdownes tpdownes enabled auto-merge October 29, 2024 01:56
@tpdownes tpdownes merged commit cb721a3 into GoogleCloudPlatform:develop Oct 29, 2024
9 of 57 checks passed
@tpdownes tpdownes deleted the update_nat branch October 29, 2024 02:50
@rohitramu rohitramu mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version-updates Added to release notes under the "Version Updates" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants