Allow users to provide a commit hash instead of git tag for Spack and Ramble installations #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Ramble installations (bugfix)
rohitramu
added
the
release-bugfix
|
I have successfully tested this change with the blueprint used for HPC Image testing, as we first identified the problem there. |
nick-stroud
approved these changes
Sep 26, 2024
rohitramu
merged commit 4737b3e
into
GoogleCloudPlatform:develop
13 of 58 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for Spack and Ramble installation.
The git commands are being run from outside the git directory, so
--git-diris set. It seems this is insufficient, and it's possible that--work-treealso needs to be set.A new argument
-Cwas introduced in git v1.8.5 (in 2013), and it sets both--git-dirand--work-tree, when given the repository's local directory path.