Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing deprecated ramble setup variables #3041

Conversation

RachaelSTamakloe
Copy link
Collaborator

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe added the release-deprecations Added to release notes under the "Deprecations" heading. label Sep 16, 2024
@RachaelSTamakloe RachaelSTamakloe force-pushed the remove_deprecated_ramble_variables branch from 2b8a598 to d397a7b Compare September 26, 2024 21:16
@RachaelSTamakloe RachaelSTamakloe force-pushed the remove_deprecated_ramble_variables branch from d397a7b to 4171c18 Compare September 26, 2024 21:44
@RachaelSTamakloe RachaelSTamakloe merged commit 1580ace into GoogleCloudPlatform:develop Sep 26, 2024
8 of 53 checks passed
@tpdownes tpdownes mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-deprecations Added to release notes under the "Deprecations" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants