-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds option to allow Kueue/Jobset to be installed on a GKE cluster via blueprints #3017
Merged
ankitkinra
merged 1 commit into
GoogleCloudPlatform:develop
from
ankitkinra:add-kueue-module
Sep 19, 2024
Merged
Adds option to allow Kueue/Jobset to be installed on a GKE cluster via blueprints #3017
ankitkinra
merged 1 commit into
GoogleCloudPlatform:develop
from
ankitkinra:add-kueue-module
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7b5f92
to
d291042
Compare
d291042
to
5a334c4
Compare
nick-stroud
reviewed
Sep 13, 2024
chengcongdu
reviewed
Sep 13, 2024
sharabiani
reviewed
Sep 16, 2024
bde3dcd
to
d2d1cc0
Compare
chengcongdu
reviewed
Sep 18, 2024
2bd5808
to
0f95409
Compare
chengcongdu
reviewed
Sep 18, 2024
chengcongdu
reviewed
Sep 18, 2024
chengcongdu
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address the comment before merging
0f95409
to
da7d70b
Compare
sharabiani
approved these changes
Sep 19, 2024
… also add to blueprints Address feedback and install downloaded manfiest to add toleration for system node pool
bd59c43
to
347b9af
Compare
bdd41ff
into
GoogleCloudPlatform:develop
9 of 51 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows blueprint to install Kueue/Jobset for a GKE cluster which reduces the manual steps required by the user to configure these frameworks.
In this PR:
Testing
Example yaml in a blueprint
Future enhancements
Submission Checklist
Please take the following actions before submitting this pull request.