Add machine type availability checks #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annuay-google
added
the
release-module-improvements
annuay-google
force-pushed
the
annuay/add-machine-type-availability-checks
branch
from
51c46f8 to
9d4d2a1
Compare
annuay-google
changed the title
|
@annuay-google please rebase this PR off the current state of the develop branch. |
tpdownes
dismissed
mr0re1’s stale review
I would like to see the Slurm 6 tests pass reliably before merging
tpdownes
requested changes
Sep 5, 2024
annuay-google
force-pushed
the
annuay/add-machine-type-availability-checks
branch
from
9d4d2a1 to
ef6d169
Compare
Rebased and ran all Slurm 6 tests. All were successful 
|
annuay-google
force-pushed
the
annuay/add-machine-type-availability-checks
branch
from
ef6d169 to
aaf4161
Compare
annuay-google
force-pushed
the
annuay/add-machine-type-availability-checks
branch
from
aaf4161 to
720a5f9
Compare
tpdownes
requested changes
Sep 9, 2024
annuay-google
force-pushed
the
annuay/add-machine-type-availability-checks
branch
6 times, most recently
from
bbbc966 to
c34a38f
Compare
…rovisioned only if the machine exists in one of the zones specified Update tools/cloud-build/daily-tests/tests/hcls.yml Co-authored-by: Tom Downes <[email protected]> Update tools/cloud-build/daily-tests/tests/hcls.yml Co-authored-by: Tom Downes <[email protected]> Use europe-west1-d in reservations.tf
annuay-google
force-pushed
the
annuay/add-machine-type-availability-checks
branch
from
1d3787e to
62acb6a
Compare
tpdownes
approved these changes
Sep 11, 2024
annuay-google
merged commit dd5647e
into
GoogleCloudPlatform:develop
11 of 52 checks passed
annuay-google
deleted the
annuay/add-machine-type-availability-checks
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add machine type- availability zone precondition. Validate infra is provisioned only if the machine exists in one of the zones specified
Submission Checklist
Please take the following actions before submitting this pull request.