Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes TreeWidth and TopologyPlugin in blueprints #2683

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

nick-stroud
Copy link
Collaborator

@nick-stroud nick-stroud commented Jun 12, 2024

As documented, TreeWidth and TopologyPlugin can be useful when debugging communication problems between Slurm nodes. This allows for these values to be set in the blueprint. Reapply (ghpc deploy -w) will updated these values on a Slurm GCP v6 cluster.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@nick-stroud nick-stroud added the do-not-merge Block merging of this PR label Jun 12, 2024
@nick-stroud nick-stroud requested a review from mr0re1 June 12, 2024 06:15
@nick-stroud nick-stroud added release-module-improvements Added to release notes under the "Module Improvements" heading. and removed do-not-merge Block merging of this PR labels Jun 14, 2024
@nick-stroud nick-stroud marked this pull request as ready for review June 14, 2024 01:20
@nick-stroud nick-stroud changed the title Tree width Exposes TreeWidth and TopologyPlugin in blueprints Jun 14, 2024
@mr0re1 mr0re1 assigned nick-stroud and unassigned mr0re1 Jun 14, 2024
@nick-stroud nick-stroud merged commit 53e0974 into GoogleCloudPlatform:develop Jun 14, 2024
31 of 57 checks passed
@alyssa-sm alyssa-sm mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants