Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct variable name and credential copying #25

Merged
merged 3 commits into from
Mar 31, 2020
Merged

fix: correct variable name and credential copying #25

merged 3 commits into from
Mar 31, 2020

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Mar 31, 2020 •
edited
Loading

This PR cleans up two small issues

  1. a var was incorrectly named
  2. the credentials creation was copying default credentials and specifying creds. This wasn't necessary as we can provide scopes when retrieving creds.

fixes #24

@crwilcox crwilcox merged commit 41e317e into master Mar 31, 2020
@kurtisvg kurtisvg deleted the credentials-without-scopes branch March 31, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'Credentials' object has no attribute 'with_scopes'
2 participants
@crwilcox @kurtisvg