Update README and setup.py #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What versions of Python can this be used with? It would be nice to have that information in the README and the setup.py. 😄 |
kurtisvg
suggested changes
Aug 15, 2019
There was a problem hiding this comment.
I think you should re-frame this into 3 sections:
- "How to install this connector"
- "How to use this connector"
- "How to make changes to this connector as a developer"
As a user of the library, I probably don't care about running tests or making changes. (but I do care about how I need to use it)
fatcat2
changed the title
Merged
added 2 commits
August 15, 2019 13:58
kurtisvg
approved these changes
Aug 16, 2019
crwilcox
reviewed
Aug 16, 2019
crwilcox
approved these changes
Aug 16, 2019
Co-Authored-By: Christopher Wilcox <[email protected]>
crwilcox
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the README with instructions on how to set up a dev environment/how to use!