Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for GOOGLE_CLOUD_QUOTA_PROJECT env var #1231

Merged
merged 1 commit into from
Feb 4, 2025
Merged

feat: add support for GOOGLE_CLOUD_QUOTA_PROJECT env var #1231

merged 1 commit into from
Feb 4, 2025

Conversation

jackwotherspoon
Copy link
Collaborator

Add support for quota_project to be set via the GOOGLE_CLOUD_QUOTA_PROJECT env var.

Order of operations for setting quota project will be as follows:

  1. Use quota_project argument passed to Connector()
  2. Use GOOGLE_CLOUD_QUOTA_PROJECT env var
  3. Set default to None (project set in environment)

Fixes #1229

@jackwotherspoon jackwotherspoon self-assigned this Jan 31, 2025
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner January 31, 2025 20:10
kgala2
kgala2 approved these changes Jan 31, 2025
View reviewed changes
Copy link

@kgala2 kgala2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackwotherspoon jackwotherspoon merged commit 5232055 into main Feb 4, 2025
15 checks passed
@jackwotherspoon jackwotherspoon deleted the quota-env-var branch February 4, 2025 16:36
@release-please release-please bot mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgala2 kgala2 kgala2 approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for GOOGLE_CLOUD_QUOTA_PROJECT env var
2 participants
@jackwotherspoon @kgala2