Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GOOGLE_CLOUD_QUOTA_PROJECT env var #1229

Closed
jackwotherspoon opened this issue Jan 30, 2025 · 0 comments · Fixed by #1231
Closed

Add support for GOOGLE_CLOUD_QUOTA_PROJECT env var #1229

jackwotherspoon opened this issue Jan 30, 2025 · 0 comments · Fixed by #1231
Assignees
@jackwotherspoon
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jackwotherspoon
Copy link
Collaborator

We should add support for reading GOOGLE_CLOUD_QUOTA_PROJECT from the environment as an alternative way of setting the quota project to be used for Cloud SQL Admin API calls.

Currently we only support quota project via the quota_project argument to Connector():

cloud-sql-python-connector/google/cloud/sql/connector/connector.py

Line 64 in 144311b

quota_project: Optional[str] = None,

Similar to GOOGLE_CLOUD_UNIVERSE_DOMAIN support that we added.
@jackwotherspoon jackwotherspoon added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jan 30, 2025
@jackwotherspoon jackwotherspoon self-assigned this Jan 30, 2025
@jackwotherspoon jackwotherspoon mentioned this issue Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
1 participant
@jackwotherspoon