test: add e2e test for CAS instances. #854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add support for CAS instances. * fix: remove an extra curly brace. * feat: upgrade google.golang.org/api to v0.190.0 for the new server_ca_mode field * fix: format the code to fix lint issue. * fix: fix some bugs in tests. * fix: fix a typo in tests. * fix: set instance name for CAS unit tests. Also renamed gotDNS to gotPSCDNS to make it clear that the DNS from PSC address. * fix: enable mocked SQL admin client to pass server_ca_mode too. * refactor: resolve some review comments. * doc: add godoc for the usage of the DNS name. * doc: fix a few typos in comments. * test: add e2e test for CAS instances. * test: fix an syntax error.
* test: resolve conflicts in test. * test: add a new line before CAS instance tests. * test: fix some lint issues.
|
Closing this PR since the #850 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.
This PR is created only to run the e2e test for PR #850.