chore: update test code to have comments #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
commented
May 7, 2024
e2e_postgres_test.go
Outdated
Comment on lines
86
to
88
| // Tell the driver to use the Cloud SQL Go Connector to create connections | ||
| // postgresConnName is Cloud SQL instance connection name, | ||
| // in the form of 'project:region:instance'. |
There was a problem hiding this comment.
let me know if you think there is a better comment for these two lines
enocom
approved these changes
May 7, 2024
| pool, err := pgxpool.NewWithConfig(ctx, config) | ||
| if err != nil { | ||
| t.Fatalf("failed to create pool: %s", err) | ||
| } | ||
| // ... etc |
There was a problem hiding this comment.
Maybe: "Call cleanup at the end of your main function when the database connection is no longer needed."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating test code to match readme sample...