Change autocommit/readonly value on connection creation #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
dzou
approved these changes
May 26, 2021
| return config.build(); | ||
| } | ||
|
|
||
| private boolean getBooleanFlag(Object value) { |
There was a problem hiding this comment.
Is this method necessary? I think options.getValue(READONLY) will always return a boolean if it's declared as a Option<Boolean> initially. (maybe)
There was a problem hiding this comment.
Unfortunately, no -- when the option is coming through a URL, it will get parsed as String. But R2DBC will likely address this in the future (r2dbc/r2dbc-spi#206), so I am hoping that this method is temporary.
meltsufin
approved these changes
May 26, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor but longstanding feature debt for parity with JDBC driver.
Also removes unused
SpannerConnectionConfigurationparameter in connection.Fixes #294, #295.