Elasticsearch tests #353
Elasticsearch tests #353
Conversation
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
| stdout: | ||
| contains: OK - green status | ||
|
|
||
| - name: Add a document |
There was a problem hiding this comment.
Can you name steps in a question form? Can add a document instead
There was a problem hiding this comment.
I rephrased the names.
| curl -s -f "${ELASTIC_URL}/_search?q=jones" | ||
| expect: | ||
| stdout: | ||
| contains: "\"name\":\"John\"" |
|
|
||
| # Wait for green status | ||
| status="$(get_cluster_status)" | ||
| while [[ "${status}" != '"green"' ]] \ |
There was a problem hiding this comment.
If you modify jq in get_cluster_status function as following: jqlang/jq#250, then you can drop ugly " here and below.
There was a problem hiding this comment.
Thanks, it's nice. Corrected.
| expected_nodes="${REPLICAS}" | ||
|
|
||
| timeout=300 | ||
| timeout_time=$(( $(date +%s) + timeout )) |
There was a problem hiding this comment.
Cluster might not be formed - do you mean not having timeouts in the test and rely on the deployer's timeout or Cloud Build's timeout? Then we rely on the execution environment for a container, which should rather be environment-agnostic.
|
|
||
| # Wait for all nodes to join the cluster | ||
| nodes_count="$(get_nodes_count)" | ||
| while [[ "${nodes_count}" -ne "${expected_nodes}" ]] \ |
There was a problem hiding this comment.
Just a question: Does it mean that running Pod can be still not connected to the cluster?
| done | ||
|
|
||
| if [[ "${nodes_count}" -eq "${expected_nodes}" ]]; then | ||
| echo "OK - all nodes joined" |
There was a problem hiding this comment.
I prefer stdout checks for ease of debugging in case of failure, even if I agree that checking the exitCode is more readable. We can return to checking the exitCode once testrunner prints the logs from both stdout and stderr in case of failure.
| done | ||
|
|
||
| if [[ "${nodes_count}" -eq "${expected_nodes}" ]]; then | ||
| echo "OK - all nodes joined" |
There was a problem hiding this comment.
I prefer stdout checks for ease of debugging in case of failure, even if I agree that checking the exitCode is more readable. We can return to checking the exitCode once testrunner prints the logs from both stdout and stderr in case of failure.
| expected_nodes="${REPLICAS}" | ||
|
|
||
| timeout=300 | ||
| timeout_time=$(( $(date +%s) + timeout )) |
There was a problem hiding this comment.
Cluster might not be formed - do you mean not having timeouts in the test and rely on the deployer's timeout or Cloud Build's timeout? Then we rely on the execution environment for a container, which should rather be environment-agnostic.
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
| fi | ||
| expect: | ||
| stdout: | ||
| equals: 'OK - all nodes found' |
There was a problem hiding this comment.
JFYI: Because of GoogleCloudPlatform/marketplace-testrunner#6 change, we will be able to drop the if statement and replace equals with something like {{ .Env.REPLICAS }}
No description provided.