-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CloudSQL option for accounts-db, ledger-db #383
Conversation
🚀 PR staged at http://35.223.94.0 |
Hi Amina! This looks good, I got the Cloud SQL instructions working on my ASM-enabled WI cluster. Ideally we have consistency between the in-cluster and Cloud SQL postgres DBs. Not sure how to turn the load_testdata script into a set of raw SQL commands. But ideally we add this data in the step when the user creates the tables manually. |
Hi @askmeegs and @cloud-pharaoh, I think that's indeed a great idea to have an option to leverage Cloud SQL here. I may have few questions:
Just sharing and wondering, thanks! |
d3832ef
to
5e76847
Compare
🚀 PR staged at http://35.223.94.0 |
Hi Mathieu,
Good catch. I do that in terraform in my test set up and I didn't realize it wasn't here. Added to the instructions.
No reason why we cannot. Just needs to be tested to make sure all is good. @askmeegs
The comment seems to imply that is the default behavior or am I misunderstanding?
Very possible. I just wanted to show an example with one of them. @askmeegs up to you now Megan if you want to do it later or as part of this PR.
A k8s Job would be a good way to run this initialization script.
|
🚀 PR staged at http://35.223.94.0 |
🚀 PR staged at http://35.223.94.0 |
🚀 PR staged at http://35.223.94.0 |
🚀 PR staged at http://35.223.94.0 |
🚀 PR staged at http://35.223.94.0 |
🚀 PR staged at http://35.223.94.0 |
1 similar comment
🚀 PR staged at http://35.223.94.0 |
🚀 PR staged at http://35.223.94.0 |
🚀 PR staged at http://35.223.94.0 |
🚀 PR staged at http://35.223.94.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚀 PR staged at http://35.223.94.0 |
Change summary: Adds a Cloud SQL option for the in-cluster Postgres ledger-db and accounts-db.
Added:
Follow-up work (filed issues for these).