Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused region tags #1421

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Conversation

bourgeoisor
Copy link
Member

@bourgeoisor bourgeoisor commented Apr 5, 2023

This removes all region tags to clean up the codebase-- This follows YAGNI principles: if we eventually need any of those tags, we can add exactly the ones needed, instead of trying to catch every possible cases ahead of time (and not needing the vast majority of them).

Removing all 110 region tags only breaks three pages, but those were already broken anyway (since the Skaffold structure changed heavily in #1221. I have already sent internal changelist #522375716 to fix those pages up.

@bourgeoisor bourgeoisor requested review from a team and yoshi-approver as code owners April 5, 2023 20:01
@snippet-bot
Copy link

snippet-bot bot commented Apr 5, 2023

Here is the summary of possible violations 😱

There is a possible violation for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to delete 110 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@NimJay
Copy link
Collaborator

NimJay commented Apr 6, 2023

Thanks for creating Changelist 522392727 to pin the 3 pages to a specific Bank of Anthos commit.
Looks like your Changelist is submitted.
I'm guessing snippet-bot check takes some time to pick up on changes:
Screenshot 2023-04-06 at 3 09 00 PM

@bourgeoisor bourgeoisor merged commit 35adb9d into main Apr 6, 2023
@bourgeoisor bourgeoisor deleted the issue-remove-unused-region-tags branch April 6, 2023 19:24
big-appled pushed a commit to big-appled/bank-of-anthos that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants