-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused region tags #1421
Conversation
Here is the summary of possible violations 😱 There is a possible violation for removing region tag in use.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to delete 110 region tags.
This comment is generated by snippet-bot.
|
This removes all region tags to clean up the codebase-- This follows YAGNI principles: if we eventually need any of those tags, we can add exactly the ones needed, instead of trying to catch every possible cases ahead of time (and not needing the vast majority of them).
Removing all 110 region tags only breaks three pages, but those were already broken anyway (since the Skaffold structure changed heavily in #1221. I have already sent internal changelist #522375716 to fix those pages up.