Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue related to RDS connection #30

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix an issue related to RDS connection #30

merged 1 commit into from
Apr 23, 2024
+31 −10

Conversation

vksampath
Copy link
Collaborator

  1. Update db_secrets.schema.json to include database name (dbname)
  2. Gracefully handle scenarios when the secret values does not include additional RDS metadata such as engine, dbInstanceIdentifier, host, port etc)

@niedzielak
Copy link
Collaborator

LGTM

@niedzielak niedzielak merged commit 868332f into master Apr 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niedzielak niedzielak niedzielak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vksampath @niedzielak