Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds script to do release setup. #481

Merged
merged 11 commits into from
Oct 24, 2017
Merged

Adds script to do release setup. #481

merged 11 commits into from
Oct 24, 2017

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Oct 24, 2017

Fixes #479 .

@codecov
Copy link

codecov bot commented Oct 24, 2017

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files          89       89           
  Lines        2135     2135           
  Branches      331      331           
=======================================
  Hits         1471     1471           
  Misses        520      520           
  Partials      144      144

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9969608...309b810. Read the comment docs.

@loosebazooka
Copy link
Contributor

presumably there's no maven mechanism for this?

@coollog
Copy link
Contributor Author

coollog commented Oct 24, 2017

This is essentially what we have for our manual instructions, just put in script for so we can just run it with a version number. It uses the mvn versions:set versions:commit command.

loosebazooka
loosebazooka previously approved these changes Oct 24, 2017
Copy link
Contributor

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, the colors, nice.

@coollog
Copy link
Contributor Author

coollog commented Oct 24, 2017

Added the newline at the end of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants