Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

Update papermill version to avoid nbconvert bug with nbconvert>=5.6 #67

Merged

Conversation

fchouteau
Copy link
Contributor

There was an nbconvert update in nbconvert=>5.6 which add an argument to run_cell, which makes papermill < 1.0.1 fail on notebook execution

File "/opt/miniconda/lib/python3.6/site-packages/papermill/preprocess.py", line 27, in preprocess
nb, resources = self.papermill_process(nb_man, resources)
File "/opt/miniconda/lib/python3.6/site-packages/papermill/preprocess.py", line 76, in papermill_process
nb.cells[index], resources = self.preprocess_cell(cell, resources, index)
File "/opt/miniconda/lib/python3.6/site-packages/nbconvert/preprocessors/execute.py", line 438, in preprocess_cell
reply, outputs = self.run_cell(cell, cell_index, store_history)
TypeError: run_cell() takes from 2 to 3 positional arguments but 4 were given

This issue has been resolved with papermill versions above 1.0.1

Ref:
Nbconvert PR: jupyter/nbconvert#1055
Papermill issue: nteract/papermill#410

The following PR upgrades papermill to >=1.0.1, which should solve the issue (at least on the use cases I ran)

@fchouteau fchouteau requested a review from gogasca as a code owner November 27, 2019 13:33
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@fchouteau
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@sirtorry
Copy link
Contributor

sirtorry commented Dec 3, 2019

thank you for this PR.

@sirtorry sirtorry merged commit 4245eeb into GoogleCloudPlatform:master Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants