Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add e2e test for hg-tgi #780

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: add e2e test for hg-tgi #780

merged 1 commit into from
Aug 29, 2024

Conversation

genlu2011
Copy link
Collaborator

@genlu2011 genlu2011 commented Aug 20, 2024

Create e2e test for hg-tgi tutorial.

Since the underlying inference-service module already has test coverage via the standard PR trigger, this e2e test is configured to run only under the following conditions:

  1. When there are changes in the tutorials-and-examples/hf-tgi directory, excluding .md files.
  2. The standard PR trigger e2e test is not required if all changes are limited to tutorials-and-examples/hf-tg directory.

@genlu2011 genlu2011 requested a review from imreddy13 August 20, 2024 23:39
@genlu2011 genlu2011 force-pushed the genlu/fix/e2e_test_hg-tgi branch from 5cfc823 to ba3f177 Compare August 20, 2024 23:45
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 force-pushed the genlu/fix/e2e_test_hg-tgi branch from ba3f177 to 8d2585f Compare August 21, 2024 17:46
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 force-pushed the genlu/fix/e2e_test_hg-tgi branch from 8d2585f to 5dc4f33 Compare August 21, 2024 19:04
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 force-pushed the genlu/fix/e2e_test_hg-tgi branch from 5dc4f33 to e399dbe Compare August 22, 2024 00:59
Change-Id: I454735bf758f5d3a28cb2a92e9c5e4c7161de8e5
@genlu2011 genlu2011 force-pushed the genlu/fix/e2e_test_hg-tgi branch from e399dbe to 1a31a82 Compare August 22, 2024 02:19
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 merged commit 203ddbc into main Aug 29, 2024
11 checks passed
leroyjb pushed a commit to leroyjb/ai-on-gke that referenced this pull request Jan 24, 2025
Change-Id: I454735bf758f5d3a28cb2a92e9c5e4c7161de8e5

Co-authored-by: Gen Lu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants