This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates request handlers to take
event
instead ofrequest
as their first argument, as discussed in #196. Request handlers need access toevent
because people that build on top of sw-toolbox may need access toevent.client
andevent.waitUntil
.I didn't move event.respondWith inside of the event handlers because it seemed potentially error-prone and more verbose, because event.respondWith has to be called synchronously inside of the handler.
Looking at this, I'm not 100% sure it's worth breaking backwards compatibility.
Two alternatives:
handler(request, values, options, event)
Thoughts?