Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: speed up prettier/eslint pre-commit hooks and use types instead of files #1477

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

@thiagowfx thiagowfx enabled auto-merge (squash) October 25, 2023 13:31
@thiagowfx thiagowfx force-pushed the thiagowfx/pre-commit branch 2 times, most recently from 457a9e0 to 8289bd5 Compare October 25, 2023 13:34
@thiagowfx thiagowfx disabled auto-merge October 25, 2023 13:41
@thiagowfx thiagowfx force-pushed the thiagowfx/pre-commit branch from 00209f6 to 2275974 Compare October 25, 2023 13:42
@thiagowfx thiagowfx changed the title ci: speed up prettier pre-commit hook ci: speed up prettier/eslint pre-commit hooks and use types instead of files Oct 25, 2023
@thiagowfx thiagowfx enabled auto-merge (squash) October 25, 2023 13:44
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify that EsLint is running only once as I had issue when it ran one time per file changed

@thiagowfx thiagowfx disabled auto-merge October 25, 2023 13:49
@thiagowfx thiagowfx force-pushed the thiagowfx/pre-commit branch from 8252215 to 63dde91 Compare October 25, 2023 13:52
@thiagowfx
Copy link
Contributor Author

I had made a mistake. It's types_or, not types. Fixed.

@thiagowfx thiagowfx enabled auto-merge (squash) October 25, 2023 13:55
@thiagowfx thiagowfx force-pushed the thiagowfx/pre-commit branch from 63dde91 to 16d9eed Compare October 25, 2023 14:02
@thiagowfx thiagowfx disabled auto-merge October 25, 2023 14:12
@thiagowfx thiagowfx merged commit c3af4d0 into main Oct 25, 2023
@thiagowfx thiagowfx deleted the thiagowfx/pre-commit branch October 25, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants