build: update TS target and fix website css (#3070)

Update TypeScript to target newer versions of ECMAScript - we run it in the browser so almost all feature are there. Made use of these new things to remove the `[...Iterator]` syntax as the new one should have better performence. Replaced the `divider` div from the template as there were small issue around hiding things using border-top does the same thing.
GoogleChromeLabs · Feb 4, 2025 · bdc806a · bdc806a
1 parent ec3df40
commit bdc806a
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 30 deletions.
diff --git a/src/bidiMapper/modules/network/NetworkProcessor.ts b/src/bidiMapper/modules/network/NetworkProcessor.ts
@@ -211,7 +211,7 @@ export class NetworkProcessor {
     const cacheDisabled = params.cacheBehavior === 'bypass';
 
     await Promise.all(
-      [...contexts.values()].map((context) => {
+      contexts.values().map((context) => {
         return context.cdpTarget.toggleSetCacheDisabled(cacheDisabled);
       }),
     );

diff --git a/src/bidiMapper/modules/session/SubscriptionManager.spec.ts b/src/bidiMapper/modules/session/SubscriptionManager.spec.ts
@@ -664,9 +664,13 @@ describe('SubscriptionManager', () => {
   });
 
   describe('unroll events', () => {
+    function unrollEventsToArray(args: any[]) {
+      return [...unrollEvents(args)];
+    }
+
     it('all Browsing Context events', () => {
       expect(
-        unrollEvents([ChromiumBidi.BiDiModule.BrowsingContext]),
+        unrollEventsToArray([ChromiumBidi.BiDiModule.BrowsingContext]),
       ).to.have.members([
         ChromiumBidi.BrowsingContext.EventNames.ContextCreated,
         ChromiumBidi.BrowsingContext.EventNames.ContextDestroyed,
@@ -685,13 +689,15 @@ describe('SubscriptionManager', () => {
     });
 
     it('all Log events', () => {
-      expect(unrollEvents([ChromiumBidi.BiDiModule.Log])).to.have.members([
-        ChromiumBidi.Log.EventNames.LogEntryAdded,
-      ]);
+      expect(
+        unrollEventsToArray([ChromiumBidi.BiDiModule.Log]),
+      ).to.have.members([ChromiumBidi.Log.EventNames.LogEntryAdded]);
     });
 
     it('all Network events', () => {
-      expect(unrollEvents([ChromiumBidi.BiDiModule.Network])).to.have.members([
+      expect(
+        unrollEventsToArray([ChromiumBidi.BiDiModule.Network]),
+      ).to.have.members([
         ChromiumBidi.Network.EventNames.AuthRequired,
         ChromiumBidi.Network.EventNames.BeforeRequestSent,
         ChromiumBidi.Network.EventNames.FetchError,
@@ -701,7 +707,9 @@ describe('SubscriptionManager', () => {
     });
 
     it('all Script events', () => {
-      expect(unrollEvents([ChromiumBidi.BiDiModule.Script])).to.have.members([
+      expect(
+        unrollEventsToArray([ChromiumBidi.BiDiModule.Script]),
+      ).to.have.members([
         ChromiumBidi.Script.EventNames.Message,
         ChromiumBidi.Script.EventNames.RealmCreated,
         ChromiumBidi.Script.EventNames.RealmDestroyed,
@@ -710,7 +718,7 @@ describe('SubscriptionManager', () => {
 
     it('discrete events', () => {
       expect(
-        unrollEvents([
+        unrollEventsToArray([
           ChromiumBidi.Script.EventNames.RealmCreated,
           ChromiumBidi.Log.EventNames.LogEntryAdded,
         ]),
@@ -722,7 +730,7 @@ describe('SubscriptionManager', () => {
 
     it('all and discrete events', () => {
       expect(
-        unrollEvents([
+        unrollEventsToArray([
           ChromiumBidi.BiDiModule.Log,
           ChromiumBidi.Log.EventNames.LogEntryAdded,
         ]),

diff --git a/src/bidiMapper/modules/session/SubscriptionManager.ts b/src/bidiMapper/modules/session/SubscriptionManager.ts
@@ -41,7 +41,7 @@ export function cartesianProduct(...a: any[][]) {
 /** Expands "AllEvents" events into atomic events. */
 export function unrollEvents(
   events: ChromiumBidi.EventNames[],
-): ChromiumBidi.EventNames[] {
+): Iterable<ChromiumBidi.EventNames> {
   const allEvents = new Set<ChromiumBidi.EventNames>();
 
   function addEvents(events: ChromiumBidi.EventNames[]) {
@@ -72,7 +72,7 @@ export function unrollEvents(
     }
   }
 
-  return [...allEvents.values()];
+  return allEvents.values();
 }
 
 export interface Subscription {

diff --git a/tools/wpt-report-builder/formatter.mjs b/tools/wpt-report-builder/formatter.mjs
@@ -242,7 +242,6 @@ function generateTestReport(map, parent) {
   }
 
   return `
-    <div class="divider"></div>
     <div class="test-card">
       <details>
         <summary class="path ${
@@ -270,7 +269,7 @@ function generateSubtestReport(subtest) {
   const name =
     subtest.name ?? removeWebDriverBiDiPrefix(subtest.path).split('/').at(-1);
 
-  return `<div class="divider"></div>
+  return `
       <div class="test-card test-card-subtest ${
         subtest.status === 'PASS' ? 'pass' : 'fail'
       }">

diff --git a/tools/wpt-report-builder/template.html b/tools/wpt-report-builder/template.html
@@ -32,13 +32,13 @@
       max-width: 1200px;
     }
 
-    .top > div > .test-card,
-    .top > div > .divider {
+    .top > div > .test-card {
       margin-left: 0;
     }
     .test-card {
       margin-left: 20px;
       max-width: 1200px;
+      border: 1px solid #a0a0a0;
     }
     .test-card-subtest {
       display: flex;
@@ -49,11 +49,6 @@
     .test-name {
       word-break: break-all;
     }
-    .divider {
-      margin-left: 20px;
-      height: 1px;
-      background: #a0a0a0;
-    }
     .non-collapsible-item {
       padding-left: 27px;
       padding-right: 15px;
@@ -165,9 +160,7 @@
       const failures = document.querySelector('.failures');
       let failureState = 'all';
       const summaryQuery = '.test-card:has(> details > .path.pass)';
-      const summaryDividerQuery = `${summaryQuery} + .divider`;
       const passingTestQuery = '.test-card.test-card-subtest.pass';
-      const passingTestDividerQuery = `${passingTestQuery} + .divider`;
       failures.addEventListener('click', () => {
         failures.innerText =
           failureState.charAt(0).toUpperCase() + failureState.slice(1);
@@ -176,12 +169,7 @@
         } else {
           failureState = 'all';
         }
-        for (const query of [
-          summaryQuery,
-          summaryDividerQuery,
-          passingTestQuery,
-          passingTestDividerQuery,
-        ]) {
+        for (const query of [summaryQuery, passingTestQuery]) {
           document
             .querySelectorAll(query)
             .forEach(

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -5,7 +5,7 @@
     "declaration": true,
     "esModuleInterop": true,
     "incremental": true,
-    "module": "ES2022",
+    "module": "ESNext",
     "moduleResolution": "node",
     "noFallthroughCasesInSwitch": true,
     "noImplicitAny": true,
@@ -23,7 +23,7 @@
     "strictFunctionTypes": true,
     "strictNullChecks": true,
     "strictPropertyInitialization": true,
-    "target": "ES2022",
+    "target": "ESNext",
     "useUnknownInCatchVariables": true
   }
 }