remove rules with side effects and undo them

GoogleChromeLabs · Jun 14, 2023 · 8049139 · 8049139
1 parent 1955789
commit 8049139
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -82,11 +82,9 @@ module.exports = {
     '@typescript-eslint/no-unsafe-member-access': 'off',
     '@typescript-eslint/no-unsafe-return': 'off',
     '@typescript-eslint/no-unused-vars': ['warn', {argsIgnorePattern: '^_'}],
-    '@typescript-eslint/prefer-nullish-coalescing': 'error',
     '@typescript-eslint/prefer-return-this-type': 'warn',
     '@typescript-eslint/require-await': 'warn',
     '@typescript-eslint/restrict-template-expressions': 'warn',
-    '@typescript-eslint/sort-type-constituents': ['error', {'checkUnions': false}],
     '@typescript-eslint/switch-exhaustiveness-check': 'error',
     'func-names': 'error',
     'import/first': 'error',

diff --git a/src/bidiMapper/domains/network/networkRequest.ts b/src/bidiMapper/domains/network/networkRequest.ts
@@ -294,8 +294,8 @@ export class NetworkRequest {
             this.#responseReceivedEvent.response.status,
           statusText: this.#responseReceivedEvent.response.statusText,
           fromCache:
-            this.#responseReceivedEvent.response.fromDiskCache ??
-            this.#responseReceivedEvent.response.fromPrefetchCache ??
+            this.#responseReceivedEvent.response.fromDiskCache ||
+            this.#responseReceivedEvent.response.fromPrefetchCache ||
             this.#servedFromCache,
           headers: NetworkRequest.#getHeaders(
             this.#responseReceivedEvent.response.headers