ci: shift automatic checks to ease debugging (#1421)

1. Move `unused variable` check from ts build to eslint. For debugging
purposes, often commenting out pieces of code is required. Sometimes it
leads to build failures, like `error 'foo' is defined but never used`.
2. Move pre-commit checks from `pre-commit` to `pre-push` stage. This is
required to be able to fix a progress without polishing out the whole
project before each commit + to speed up the commits.

---------

Co-authored-by: Maksim Sadym <[email protected]>

.eslintrc.js

@@ -81,7 +81,7 @@ module.exports = {
     '@typescript-eslint/no-unsafe-enum-comparison': 'warn',
     '@typescript-eslint/no-unsafe-member-access': 'off',
     '@typescript-eslint/no-unsafe-return': 'off',
-    '@typescript-eslint/no-unused-vars': ['warn', {argsIgnorePattern: '^_'}],
+    '@typescript-eslint/no-unused-vars': ['error', {argsIgnorePattern: '^_'}],
     '@typescript-eslint/prefer-return-this-type': 'warn',
     '@typescript-eslint/require-await': 'warn',
     '@typescript-eslint/restrict-template-expressions': 'off',

.pre-commit-config.yaml

@@ -20,7 +20,7 @@
 #
 # Apply all pre-commit hooks to all files:
 #   $ pre-commit run --all-files
-default_stages: [pre-commit]
+default_stages: [pre-push]
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v4.4.0

README.md

@@ -153,6 +153,10 @@ We use [cddlconv](https://github.com/google/cddlconv) to generate our WebDriverB
 
 Refer to the documentation at [.pre-commit-config.yaml](.pre-commit-config.yaml).
 
+```sh
+pre-commit install --hook-type pre-push
+```
+
 ### Starting the Server
 
 This will run the server on port `8080`:

tsconfig.base.json

@@ -14,8 +14,8 @@
     "noImplicitThis": true,
     "noPropertyAccessFromIndexSignature": true,
     "noUncheckedIndexedAccess": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
     "resolveJsonModule": true,
     "sourceMap": true,
     "strict": true,