Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/microsite #99

Merged
merged 19 commits into from
Nov 26, 2019

Conversation

anton-karlovskiy
Copy link
Contributor

@anton-karlovskiy anton-karlovskiy commented Nov 22, 2019

@addyosmani

This PR is not ready to be merged yet.
Just the Microsite build configuration is left. Since you might want to see the codebase, this PR is created.

Microsite is completed, and up and running on https://adaptive-loading.web.app/.

@anton-karlovskiy
Copy link
Contributor Author

anton-karlovskiy commented Nov 25, 2019

@addyosmani

This PR is ready for review.

Microsite build configuration is set.
cna-memory-considerate-animation is deployed to https://adaptive-loading.web.app/cna-memory-considerate-animation which was up and running on some limited Firebase account.
cna-memory-considerate-animation build configuration is set.

@anton-karlovskiy
Copy link
Contributor Author

@addyosmani

Node apps are updated for serving static assets.

@addyosmani
Copy link
Collaborator

@anton-karlovskiy could you rebase this PR against master now that we've landed the updates to demos?

@anton-karlovskiy
Copy link
Contributor Author

@addyosmani

Let me handle this and update you shortly.

@anton-karlovskiy
Copy link
Contributor Author

@addyosmani

For cna-memory-considerate-animation project, build version was not working, although dev version working.
The cause was because we imported css from react-toggle package.

I tried all workarounds but did not help. So I just wrote the css in the component and it's fixed.
vercel/next-plugins#266
vercel/next-plugins#267

Please review and merge it.

Copy link
Collaborator

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyosmani addyosmani merged commit 3c10845 into GoogleChromeLabs:master Nov 26, 2019
@anton-karlovskiy
Copy link
Contributor Author

@addyosmani

Thank you for your quick merge. I appreciate it.

@anton-karlovskiy anton-karlovskiy deleted the feature/microsite branch November 26, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants