Ensure that ignoreUrlParametersMatching works with directoryIndex #762
Conversation
|
Fixed. |
|
I've added some additional comments and refactored some of the variables, and hopefully it's mergeable now. I had initially tried to come up with a more straightforward way of testing the actual functionality, and what I ended up with was about as direct as I could figure out. (Stubbing out some of the |
| promiseChain.then(() => { | ||
| // Make sure that the cache.match() stub was called, indicating that | ||
| // there was a match against the precached URL. | ||
| if (stub.called) { |
There was a problem hiding this comment.
What is caches.match called with? Should it be with or without the directoryIndex value or not?
There was a problem hiding this comment.
Added in a check.
| // Request the URL without the directory index, but with the URL param. | ||
| request: new Request(urlToRequest), | ||
| }); | ||
| fetchEvent.respondWith = (promiseChain) => { |
There was a problem hiding this comment.
Can you stub this out? Would make it a little easier to read / follow if you could
There was a problem hiding this comment.
I don't think I can stub out respondWith() and still get things to work, no. (I copied this pattern from other tests in this suite, e.g. the previous test in this file.)
R: @addyosmani @gauntface
Fixes #758
This fixes a small bug due to using the wrong variable inside of our WorkboxSW precache route.