Deprecated plugin terser-rollup #3240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tropicadri Needs PR pls |
Wombosvideo
approved these changes
Oct 28, 2023
Havunen
reviewed
Dec 10, 2023
| @@ -27,6 +27,7 @@ | |||
| "@rollup/plugin-babel": "^5.2.0", | |||
| "@rollup/plugin-node-resolve": "^11.2.1", | |||
| "@rollup/plugin-replace": "^2.4.1", | |||
| "@rollup/plugin-terser": "^0.4.3", | |||
There was a problem hiding this comment.
you should also delete the "rollup-plugin-terser" plugin as its replaced with "@rollup/plugin-terser"
|
is this going to be merged ? |
|
Changes fixed in this PR: #3170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated plugin terser-rollup
(https://github.com/GoogleChrome/workbox/blob/v6/CONTRIBUTING.md).**
Fixes #3200
When creating a react app with create-react-app this peer dependency gives an error.