Fix quotation chars when eval-cheap-source-map is used #2847
+214
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @tropicadri
Fixes #2729
Because
InjectManifestadds JSON serialized data to compiled JavaScript files, it can sometimes lead to invalid JavaScript if the compiled JS is itself wrapped in a string—that's what can happen in variouswebpacksourcemap modes.In some modes, the string that it's wrapped in is terminated with
"characters, so the serialized JSON needs to use'. In other modes, apparently, the string it's wrapped in is terminated with'characters, so the serialized JSON needs to use". This PR accounts for one of those modes, which only happens wheneval-cheap-source-mapand minimization are used.(This PR also picked up a few changes to
package.jsonandpackage-lock.jsonfiles that appear not to have been committed following the previous PR.)