-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to add plugins to precaching lifecycle #1138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the one string change.
* | ||
* @param {Array<Object>} newPlugins | ||
* | ||
* @alias workbox.precaching.suppressWarnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suppressWarnings => addPlugins
Changes Unknown when pulling aeb3cfd on precache-plugins into ** on v3**. |
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 152% of our max size budget. Total Size: 22.32KB Gzipped: 8.89KB |
Changes Unknown when pulling 3f21d85 on precache-plugins into ** on v3**. |
R: @jeffposnick
This adds plugins to precaching so a developer could add in the broadcast cache update behavior if they want it.